fix: check stderr for json errors in TS -> Go call#6641
Merged
thomasschafer merged 1 commit intomainfrom Mar 17, 2026
Merged
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Contributor
1df523a to
7786c13
Compare
This comment has been minimized.
This comment has been minimized.
snyk-tim
reviewed
Mar 13, 2026
7786c13 to
248683e
Compare
This comment has been minimized.
This comment has been minimized.
snyk-tim
approved these changes
Mar 16, 2026
248683e to
4364873
Compare
This comment has been minimized.
This comment has been minimized.
4364873 to
0b49122
Compare
This comment has been minimized.
This comment has been minimized.
0b49122 to
30aa63c
Compare
PR Reviewer Guide 🔍
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Submission Checklist
are release-note ready, emphasizing
what was changed, not how.
What does this PR do?
Previously in the TS -> Go call performed by the uv plugin, JSON errors were assumed to be on stdout. However, from some testing they appear to be written to stderr, at least in the tests I've performed. This PR updates the error handling to check both sources.
How should this be manually tested?
In a uv project, add or remove a dependency in the
pyproject.tomlwithout updating theuv.lock. If you then runsnyk monitoryou should see the following error:On this branch you should instead see:
What's the product update that needs to be communicated to CLI users?
None